Fix: Cannot update value of attribute with reserved name when it starts empty #841
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all, first PR here 👋 .
I observed this bug on a case that I have a field with the name
data
and I was able to create a record and update it without any issues if the first time I create the record with a value that is not empty.If the record is created with empty value in the
data
field I cannot update it via admin.Took me a while to understand the checks so I added a comment.
At the end, my solution was just removing the check
and getattr(obj, reserved_field_name, None)
.I thought about adding an or condition and check if the attribute had a value on the
obj
orform_data
but I didn't saw the point of it. Maybe I'm missing something.