Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit_form_query documentation example #777

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

lukeclimen
Copy link
Contributor

@lukeclimen lukeclimen commented May 30, 2024

The documentation example give for the edit_form_query in the cookbook references an older implementation of the function. This updates the cookbook to provide a working example.

fixes #733

@lukeclimen
Copy link
Contributor Author

Hi @aminalaee, I wanted to update the docs to match the updated version of the edit_form_query, so I've submitted a small PR that updates the cookbook example. I have local tests that I've used to validate that this works as expected, and can add a commit if you'd like them included as well!

Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@aminalaee aminalaee merged commit b51c952 into aminalaee:main Jun 11, 2024
5 checks passed
@aminalaee aminalaee mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ModelView.form_query property to create form-filtering feature
2 participants