Add searchable and sortable relation columns #573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 6, 2023 22:26
Signed-off-by: Corinna Wieken <[email protected]>
…r sorting in list view Signed-off-by: Corinna Wieken <[email protected]>
Signed-off-by: Corinna Wieken <[email protected]>
Signed-off-by: Corinna Wieken <[email protected]>
Signed-off-by: Corinna Wieken <[email protected]>
Signed-off-by: Corinna Wieken <[email protected]>
Signed-off-by: Corinna Wieken <[email protected]>
cwieken
force-pushed
the
searchable-and-sortable-relation-columns
branch
from
69de538
to
ada2a08
Compare
|
@aminalaee |
aminalaee
reviewed
Aug 22, 2023
There was a problem hiding this comment.
Thank you for the PR, but I think it'd be easier to discuss the approach first in the issue/discussion before doing it.
I think it's ideal if we could keep the config in the same one i.e. doing this:
class UserAdmin(...):
column_sortable_list = ["address.street"]Instead of introducing a new config for this, but not sure how much effort it is so I will take look and let you know.
|
This is already implemented with a different API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented the feature to define foreign key columns (relation columns) to be used for searching and sorting in list view.
This should also cover discussion #514.