Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unnecessary joins in different pages #476

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Fix unnecessary joins in different pages #476

merged 2 commits into from
Apr 20, 2023

Conversation

aminalaee
Copy link
Owner

Fixes #474

There are 3 areas:

  • Details page
  • Edit page
  • Delete

In details it should respect column_details_list and column_details_exclude_list
In edit it should respect form_columns and form_excluded_columns
In delete we shouldn't do any joins.

@aminalaee aminalaee changed the title Avoid unnecessary joins in different pages Fix unnecessary joins in different pages Apr 20, 2023
@aminalaee aminalaee merged commit dd723ea into main Apr 20, 2023
@aminalaee aminalaee deleted the avoid-extra-joins branch April 20, 2023 08:15
@aminalaee aminalaee mentioned this pull request Apr 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@aminalaee