Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug to allow nullable zero values #445

Merged
merged 4 commits into from
Mar 15, 2023
Merged

Fix bug to allow nullable zero values #445

merged 4 commits into from
Mar 15, 2023

Conversation

ovginkel
Copy link
Contributor

Bugfix: Previously incorrectly sets updates with 0 as value to None/NULL.

@ovginkel
Update _queries.py
b6f0bae 
Bugfix: Previously incorrectly sets updates with 0 as value to None/NULL.
@ovginkel
Update _queries.py
8833505 
Fix linting errors
aminalaee
aminalaee reviewed Mar 13, 2023
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. One small comment.

sqladmin/_queries.py Show resolved Hide resolved
aminalaee
aminalaee reviewed Mar 14, 2023
View reviewed changes
sqladmin/_queries.py Outdated Show resolved Hide resolved
sqladmin/_queries.py Outdated Show resolved Hide resolved
@aminalaee aminalaee changed the title Update _queries.py Fix bug to allow nullable zero values Mar 15, 2023
@aminalaee aminalaee mentioned this pull request Mar 15, 2023
Merged
@aminalaee aminalaee merged commit 3aa9125 into aminalaee:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ovginkel @aminalaee