Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve items list UI #349

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Improve items list UI #349

merged 2 commits into from
Oct 17, 2022

Conversation

ischaojie
Copy link
Contributor

Changes:

  1. Move Select items per page after pagination.
  2. Ensure alignment.
  3. Ensure actions along with the checkbox.

Preview:
image

And another piece of advice: It's better to move the actions button(view/edit/delete) to the end?

aminalaee
aminalaee requested changes Oct 10, 2022
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution, The UI can be improved a lot.

sqladmin/templates/list.html Show resolved Hide resolved
aminalaee
aminalaee approved these changes Oct 17, 2022
View reviewed changes
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@aminalaee aminalaee changed the title Better items list interface Improve items list UI Oct 17, 2022
@aminalaee aminalaee merged commit 18f74f4 into aminalaee:main Oct 17, 2022
@ischaojie ischaojie deleted the new-ui branch October 17, 2022 13:28
@aminalaee aminalaee mentioned this pull request Nov 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminalaee aminalaee aminalaee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ischaojie @aminalaee