Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of iterable fields #204

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

okapies
Copy link
Contributor

@okapies okapies commented Jun 22, 2022

Fixes #196.
Fixes #203.

sqladmin/application.py Outdated Show resolved Hide resolved
sqladmin/templates/details.html Show resolved Hide resolved
sqladmin/models.py Outdated Show resolved Hide resolved
sqladmin/models.py Outdated Show resolved Hide resolved
Copy link
Owner

@aminalaee aminalaee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks a lot @okapies .

@aminalaee aminalaee merged commit 7b5f592 into aminalaee:main Jun 22, 2022
@aminalaee
Copy link
Owner

BTW it would be great not to combine two issues in one PR, it makes both review and history cleaner. Thanks again 👍

@okapies okapies deleted the feature/fix-iterable-rel branch June 22, 2022 08:09
@aminalaee aminalaee mentioned this pull request Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatted str should not be treated as Iterable column_formatters doesn't work with one-to-many relation
2 participants