Use __class__ when impl is not callable #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okapies
force-pushed
the
feature/forms-non-callable-impl
branch
from
a4991c8 to
526639d
Compare
|
I'm sorry for the inconvenience, but please run the tests again. @aminalaee |
|
@okapies it's ok. I think it might be missing the testsl coverage now. |
|
We're not able to test it at the moment because there is no way to configure a custom converter directly (#93 (comment)) from outside of |
aminalaee
force-pushed
the
feature/forms-non-callable-impl
branch
from
e617f2a to
8c2b2d3
Compare
|
@okapies I have to close this PR and use the other one which also includes the test, I hope you understand this and thank you for the PR. |
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #176.