-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is Node v8.x required? #224
Comments
it was done in #218, presumably to be able to transpile to a later target. |
It's not really required. As a maintainer I didn't want to handle bug reports for older versions. But if you need support for older versions I'll lower the node version requirement. Should be as simple as a babel-preset-env target change and engines version change |
If we could remove the requirement in |
eslint itself requires node 4, and babel 7 requires node 4 as well i think - so removing it isn't an option, but dropping it down to 4 should be. |
Makes sense, ty for lmk
…On April 25, 2019 11:09:01 PM UTC, Jordan Harband ***@***.***> wrote:
eslint itself requires node 4, and babel 7 requires node 4 as well i
think - so removing it isn't an option, but dropping it down to 4
should be.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#224 (comment)
|
Yarn supports >=8 so we're locked to that same semver because of users who install this lib with yarn |
Um, that’s not how it works - npm users aren’t locked to that, and older versions of yarn won’t require node 8. An eslint plugin should always support every node version eslint supports. |
The latest version does, but there’s no reason we need to use > v6 - v7 only changes prerelease logic. Let’s stop looking for excuses to drop support, and try to support as far back as possible? |
* fix: #224 * downgrade semer to @6.3.0 * Update package.json Co-Authored-By: Jordan Harband <[email protected]> Co-authored-by: Jordan Harband <[email protected]>
https://github.com/amilajack/eslint-plugin-compat/blob/master/package.json#L70
The text was updated successfully, but these errors were encountered: