Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update views.py #1810

Merged

Conversation

dinger1986
Copy link
Collaborator

add mesh company name to initial setup

@dinger1986
Copy link
Collaborator Author

I assume this is failing due to it not knowing what companyname is but thats pulled from the frontend?

@wh1te909
Copy link
Member

the tests need to be updated as well, see https://github.com/amidaware/tacticalrmm/pull/1810/checks#step:10:979
we fake the data from the frontend with our unit tests so just need to add a company name to the payload

@dinger1986
Copy link
Collaborator Author

so added to tests.py is that right? will it run against that or does the tests.py need pr'd first?

@dinger1986
Copy link
Collaborator Author

forgot the ,

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.20%. Comparing base (0528ecb) to head (a23d811).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1810   +/-   ##
========================================
  Coverage    79.20%   79.20%           
========================================
  Files          138      138           
  Lines         9664     9665    +1     
========================================
+ Hits          7654     7655    +1     
  Misses        2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wh1te909
Copy link
Member

yup tests are passing now

@wh1te909 wh1te909 merged commit 39fd83a into amidaware:develop Mar 21, 2024
4 checks passed
@dinger1986 dinger1986 deleted the dinger1986-add-mesh-coname-to-initial branch April 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants