Update InitialSetup.vue #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wh1te909
reviewed
Mar 21, 2024
src/views/InitialSetup.vue
Outdated
| @@ -109,6 +141,7 @@ export default { | |||
| this.$axios.get("/core/settings/").then((r) => { | |||
| this.allTimezones = Object.freeze(r.data.all_timezones); | |||
| this.timezone = r.data.default_time_zone; | |||
| this.companyname = r.data.mesh_company_name; | |||
There was a problem hiding this comment.
we don't actually need this line cuz it will be empty on first setup, and you already initialized it to any empty string up in the data section so this is redundant.
There was a problem hiding this comment.
I had wondered about that one, thanks
|
merged, just made some style changes so that the company name text box is consistent with the other text boxes, looked kind of weird |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added company name to initial setup screen