Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

feature/verify-email#171

Merged
B3rry merged 4 commits into
developfrom
feature/verify-email
May 16, 2019
Merged

feature/verify-email#171
B3rry merged 4 commits into
developfrom
feature/verify-email

Conversation

@B3rry
Copy link
Copy Markdown
Contributor

@B3rry B3rry commented Apr 17, 2019

Signed-off-by: Jon Berry jon@jonberry.co

Related Tickets

Other Repos' PR(s) Intended to Work With This PR

How Things Worked (or Didn't) Before This PR

Users of scope admin could not get a list of platform users.

How Things Work Now (And How to Test)

  • Enables users of type admin to authenticate and view patient data, as this call is needed to present information regarding the status of a user's verification.
    • Verify an admin user can log in on the web portal, and see results when visiting /accounts

Readiness

  1. This PR has full test coverage (If this PR fixes a bug, you must add test cases respresentative of the bug).
  2. This PR passes all automated tests.
  3. This PR has no linting errors.
  4. This PR has no hardcoded UI strings or other obvious issues.
  5. This PR has been updated to include all changes from develop.
  6. This PR's changes to configuration files have been documented in all appropriate places (such as but not limited to README.md), if applicable.
  7. This PR's required changes outside of the scope of this repository have been documented in this pull request.

Signed-off-by: Jon Berry <jon@jonberry.co>
@B3rry B3rry changed the title Enable Users to Verify Email Enable Admin users to authenticate Apr 22, 2019
Copy link
Copy Markdown
Contributor

@mountHouli mountHouli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the lack of self-research. I'm out of time for this review as my plane is about to land and vacation is about to start!! :)

  1. Why must admin users be able to login to orange-web to see verification status? Shouldn't only programAdministrators be able to do this?

  2. Please fill out the PR checklist.

@mountHouli mountHouli changed the title Enable Admin users to authenticate feature/verify-email May 8, 2019
@B3rry B3rry merged commit 234df83 into develop May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants