Update basic packages and testing packages #20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Y'all know what this is about. No JIRA ticket for this.
Bunch of various things needed fixing beyond the package updates, so I've included them here just because:
istanbul
tonyc
since the former is deprecated (with a security vulnerability warning in a child package)mocha
so had to include auseUnifiedTopology
flag in the default connectionyarn test:coverage
andyarn test:check-coverage
work (previously they failed to callyarn pretest
properly)SECURITY VULNERABILITIES RESOLVED:
For the record, you can check what child packages belong to parent packages by doing
npm ls ${childPackage}
mongoose
debug
since we weren't using it (nor wasnyc
using it)nyc
has an updatedhandlebars
thereby satisfying the version requirementeslint
mocha
satisfies version requirement fordiff
eslint-watch
satisfies version requirement forbraces
commitizen
,mocha
,coveralls
, and addingnyc
satisfied version requirements forjs-yaml
coveralls
satisfies version requirement fortunnel-agent
fstream
removed (was a child of one of the packages I removed)tar
removed (was a child of one of the packages I removed) -- current child frombcrypt
is well above the minimum required version (min req:2.2.2
, current remaining:4.4.10
)express-validation
satisfied child version oflodash
express-winston
, but moving from v2 to v4 requires a Winston migrationcommitizen
version has child version oflodash
at4.17.14
which puts it under the required version4.17.15
-- look into using an alternative (which is another migration)supertest
version has child version ofextend
at3.0.0
which puts it under the required version3.0.2
-- consider only usingsupertest-as-promised
instead or simplyrequest
commitizen
satisfies minimum required version formerge
Extraneous (not sure what to do about these...):
stringstream
is-my-json-valid