Replace TrustCell implementation with atomic_refcell::AtomicRefCell #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imberflur
commented
Feb 5, 2023
Comment on lines
+552
to
+556
| /// # Safety | ||
| /// | ||
| /// If this is used to replace the `Box<dyn Resource>` with a different one, the new one must | ||
| /// have a `TypeId` that matches the one in the `ResourceId` provided here. | ||
| pub unsafe fn try_fetch_internal( |
Contributor
Author
There was a problem hiding this comment.
Oh almost forgot!
The one other thing I did in these changes is to mark this method as unsafe since it would otherwise allow safely swapping out the Box<dyn Resource> stored at a particular ResourceId with any other arbitrary Box<dyn Resource> that doesn't necessarily correspond to the ResourceId.
Merged
Imberflur
force-pushed
the
replace-trustcell-with-atomicrefcell
branch
from
8bcc2b8 to
967a7d0
Compare
Also mark a method `unsafe` that would otherwise allow safe code to swap the trait object stored at a particular `ResourceId`.
Imberflur
force-pushed
the
replace-trustcell-with-atomicrefcell
branch
from
967a7d0 to
b119397
Compare
torkleyy
approved these changes
Apr 25, 2023
Member
torkleyy
left a comment
torkleyy
left a comment
There was a problem hiding this comment.
Looks good to me! Good catch on the unsafe function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
TrustCellwithatomic_refcell::AtomicCellwhich provides near identical functionality.Advantages of this change:
atomic_refcelluses an alternative strategy to handle overflows of the read counter which allows for a single atomic operation when acquiring a read guard.TrustCellimplementation reduces the amount ofunsafecode in this crate.Based on top of commits from: #223Waiting on: mozilla/atomic_refcell#18