Added option "Convert to UTF-8" #166
Conversation
…m language specific charsets to UTF-8.
|
is this really needed? does setting character set for subtitles not solve this? which service has this issue? can we not make it a service fix rather than global fix? |
|
Hi amet, it's not meant as a fix rather as an extending option.. My motivation to implement such a thing was the fact that I usually do some timing and editing on Ubuntu which also uses UTF-8 as a default encoding. So does my TV, tablet, phone.. Needless to say you don't have to touch settings when watching a movie with Spanish, German or French subtitles.. I don't want to force you to pull it, it's just an option for those who might be interested.. ;-) Maybe it's just me.. ;-) |
|
If I understand your code correctly you have an internal table with possible source codecs for all subtitles you download and you do a try-fail test to see in conversion works? I agree with you that the option doesn't hurt the ones that don't activate it, but I'm quite sure the approach can fail in some instances. The fact that the source file doesn't say the encoding used is always a pain in the ass and it is true that there are no fail-proof methods to re-encoding. I have to say I don't feel totally fine with your solution, but can't also imagine a better one so I wouldn't oppose to it. And as a side question, what do you use for timing and editing? |
|
Hi jurrabi, you got it. There's also a need to expand the table for other languages as I don't know all encodings involved. I agree the solution isn't bulletproof at all but I'm not sure how to make it any better.. Well, fell in love with Gnome Subtitles.. ;-) Any alternative? |
|
No idea. That's why I was asking. Will give it a try. |
|
what benefits do we see in XBMC? I think XBMC handles all subs fine, I think if you need to edit them it might be an option to convert before you edit. I dont mind it in, but you know how users go about it... "stuff doesn't work, lets start clicking" :) |
|
I think (or feel) that some subtitles that show wrongly in xbmc (for example latin encoded in non-English systems with utf-8 as base) might get fixed for some people. But have not found a sample (haven't searched for it neither). I also share your reticent, but I don't see also any hurt. Other than people might start complaining about the convert to utf-8 option not working properly or getting reports from people that activate without knowing and start complaining about weird chars... on second thought, don't merge ;) I'm a weathercock that way :D . |
|
Setting the character set when it comes to Hebrew subtitles does nothing on Ubuntu. Its also a good idea if xbmc is sitting in a bigger network and you want to keep all your subtitles in the same encoding. This is actually a feature I'd like to see |
|
Hi, did this get resolved, I do have the very same problem with Czech subtitles... |
|
Man, this in ancient history. I don't think amet is in charge of subtitles anymore... Maybe try the forum? |
|
@jurrabi Where is the most recent code located? |
This option enables automatic subtitles conversion from language specific charsets to UTF-8.
It's handy at least for Czech (windows-1250, iso-8859-2). This patch is just a quick hack but it works fine for me.. Maybe someone else is also looking for something similar..