Declare dependencies on expected flake8 plugins.#420
Closed
nuclearsandwich wants to merge 1 commit intorollingfrom
Closed
Declare dependencies on expected flake8 plugins.#420nuclearsandwich wants to merge 1 commit intorollingfrom
nuclearsandwich wants to merge 1 commit intorollingfrom
Conversation
These flake8 plugins have been in the from-source setup instructions for ROS 2 a long time. For Ubuntu 22.04 we finally got all of them packaged so we can start removing pip packages from our installation requirements. I think this change should be back-portable to Humble but it can't go back to Focal because not all of these packages are available there. Signed-off-by: Steven! Ragnarök <steven@nuclearsandwich.com>
Contributor
Author
|
@ros-pull-request-builder retest this please |
|
Nice, it'll simplify CI setups! Would be great to have as part of the upcoming release – any reasons to delay the merge? |
Contributor
|
So we partially did this in #454, so closing this out as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These flake8 plugins have been in the from-source setup instructions for ROS 2 a long time. For Ubuntu 22.04 we finally got all of them packaged so we can start removing pip packages from our installation requirements.
I think this change should be back-portable to Humble but it can't go back to Focal because not all of these packages are available there.
This PR requires ros/rosdistro#35197