add CONFIG_EXTRAS_POST to ament_package()#123
Merged
dirk-thomas merged 1 commit intomasterfrom Mar 22, 2018
Merged
Conversation
Contributor
Author
|
I am not sure about the naming of this. Maybe someone has a better proposal? |
dirk-thomas
added
in review
mikaelarguedas
approved these changes
Mar 14, 2018
Contributor
mikaelarguedas
left a comment
mikaelarguedas
left a comment
There was a problem hiding this comment.
lgtm.
I couldn't find a better name for the argument so let's go with CONFIG_EXTRA_POST 👍
This still requires the content of the file (e.g. libraries) to be provided in the right order. As discussed offline with @dirk-thomas this is reasonable as reordering on behalf of users will likely be both tricky and confusing as the link line will not directly match what the user provided
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connect to ros2/ros2#468.