Repository navigation
[ROCm][Perf][GLM-5.3-Flash] Carry vllm#58584 rebased onto ac9126e5 - #24
Open
amd-sriram wants to merge 9 commits into
Open
amd-sriram wants to merge 9 commits into
amd-sriram wants to merge 9 commits into
Conversation
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit e6969ab)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit 50a3ade)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit 86e1a03)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit 42675ca)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit 133e5ae)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit c6212db)
…more than one place Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit 80f1c1e)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit ed8e7dd)
Signed-off-by: simondanielsson <simon.danielsson99@hotmail.com> (cherry picked from commit b43a03f)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Carry of vllm-project/vllm#58584 (BF16 split-K kernel for GLM-5.3-Flash sparse MLA decode, by @simondanielsson) rebased onto
ac9126e58aa7bbab1856ba6593ba4d5003fea516, so it can be built on that nightly.The upstream PR no longer applies there: its branch merged
mainafter vllm-project#58569 landed, its early commits predate vllm-project#58569, and its last commit (test: tighten tests) edits tests that only exist after vllm-project#58569.Changes
ac9126e5build carried).test: tighten tests: one conflict intests/kernels/attention/test_rocm_triton_attn_dsv4.py, resolved to the commit's intent (droptest_sparse_attn_decode_bf16_writes_caller_output, narrownum_splits) without importing the [ROCm][Perf][GLM-5.3-Flash] Remove redundant copy after ragged sparse MLA vllm-project/vllm#58569 prefill tests that the upstream side of the conflict carried.No source change beyond vllm-project#58584. Close this once a nightly containing vllm-project#58569 is used, or vllm-project#58584 merges.