Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: manage multiple edge devices in PWA #757

Merged
merged 52 commits into from
Nov 3, 2021
Merged

Conversation

ivelin
Copy link
Contributor

@ivelin ivelin commented Oct 23, 2021

Purpose

Currently users can only manage one edge device in the PWA.
Closes #563.

Approach

Store known user devices as the user connects to the for the first time. Then let the user switch the current active device selection between list of all known user devices.

Merge Checklist

  • The code change is tested and works locally.
  • The user and dev documentation is up to date.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

ivelin added 23 commits October 7, 2021 14:15
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Manifest does not contain a suitable icon - PNG, SVG or WebP format of at least 144 px is required, the sizes attribute must be set, and the purpose attribute, if set, must include any.
No supplied icon is at least 144 px square in PNG, SVG or WebP format, with the purpose attribute unset or set to any

Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
Signed-off-by: ivelin <[email protected]>
@gitpod-io
Copy link

gitpod-io bot commented Oct 23, 2021

@commit-lint
Copy link
Contributor

commit-lint bot commented Oct 23, 2021

Chore

Bug Fixes

  • pwa error - no icon with purpose anyFailure reason (6ee6ada)

Checkpoint

  • fixing discovery side effect errors (f74c3f7)

Contributors

ivelin

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@ivelin ivelin marked this pull request as draft October 23, 2021 16:33
Signed-off-by: ivelin <[email protected]>
@netlify
Copy link

netlify bot commented Oct 26, 2021

A reviewer left a comment:

recording

Testing NETLIFY

Browser metadata
Path:      /settings
Browser:   Chrome 95.0.4638.54 on Mac OS 10.15.7
Viewport:  1280 x 670 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@netlify
Copy link

netlify bot commented Oct 26, 2021

A reviewer left a comment:

TESTING NETLIFY

Browser metadata
Path:      /settings
Browser:   Chrome 95.0.4638.54 on Mac OS 10.15.7
Viewport:  1280 x 670 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

@codecov
Copy link

codecov bot commented Nov 3, 2021

Codecov Report

Merging #757 (a404c52) into master (6ee362f) will decrease coverage by 5.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #757      +/-   ##
==========================================
- Coverage   86.18%   80.56%   -5.63%     
==========================================
  Files          41       45       +4     
  Lines        1419     1487      +68     
  Branches      125      132       +7     
==========================================
- Hits         1223     1198      -25     
- Misses        196      289      +93     
Impacted Files Coverage Δ
ambianic-ui/src/views/Settings.vue 54.54% <0.00%> (-26.10%) ⬇️
...ypress/integration/ambianic-tests/snackbar.spec.js 78.57% <0.00%> (-21.43%) ⬇️
ambianic-ui/src/views/Timeline.vue 35.34% <0.00%> (-15.10%) ⬇️
ambianic-ui/src/components/NavBar.vue 87.50% <0.00%> (-12.50%) ⬇️
...tegration/ambianic-tests/remote-connection.spec.js 90.56% <0.00%> (-4.03%) ⬇️
ambianic-ui/src/store/pnp.js 98.45% <0.00%> (-1.16%) ⬇️
ambianic-ui/src/store/index.js 50.00% <0.00%> (ø)
ambianic-ui/src/views/Help.vue 100.00% <0.00%> (ø)
ambianic-ui/src/views/Home.vue 100.00% <0.00%> (ø)
ambianic-ui/src/views/About.vue 100.00% <0.00%> (ø)
... and 28 more

@netlify
Copy link

netlify bot commented Nov 3, 2021

Comment has been resolved by Ivelin Ivanov

A reviewer left a comment:

Multi-device support pre-release.

recording

Browser metadata
Path:      /timeline
Browser:   Chrome 95.0.4638.69 on Mac OS 10.15.7
Viewport:  759 x 858 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Unresolved

@ivelin ivelin marked this pull request as ready for review November 3, 2021 17:16
@ivelin ivelin merged commit 72f72ba into ambianic:master Nov 3, 2021
github-actions bot pushed a commit that referenced this pull request Nov 3, 2021
# [2.21.0](v2.20.0...v2.21.0) (2021-11-03)

### Features

* manage multiple edge devices in PWA ([#757](#757)) ([72f72ba](72f72ba)), closes [#758](#758) [#753](#753) [#741](#741) [#711](#711) [#705](#705) [#660](#660) [#659](#659) [#601](#601) [#595](#595) [#589](#589) [#563](#563) [#408](#408) [#370](#370) [#329](#329) [#327](#327) [#302](#302) [#299](#299)
@ivelin
Copy link
Contributor Author

ivelin commented Nov 3, 2021

🎉 This PR is included in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ivelin ivelin added the released label Nov 3, 2021
@ivelin
Copy link
Contributor Author

ivelin commented Nov 16, 2021

Closes #467

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightweight support for multiple edge devices
1 participant