Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensive test coverage for p2p layer #601

Closed
ivelin opened this issue Apr 5, 2021 · 2 comments
Closed

Extensive test coverage for p2p layer #601

ivelin opened this issue Apr 5, 2021 · 2 comments
Labels
released tests Test coverage wontfix This will not be worked on

Comments

@ivelin
Copy link
Contributor

ivelin commented Apr 5, 2021

Is your feature request related to a problem? Please describe.
p2p is one of the more complex layers in Ambianic. We depend on secure p2p to preserve user privacy and control.
However it's one of the least well covered layers in terms of test automation.

With dependency on webrtc, http-proxy and PnP discovery, there are many cases that affect UX which need to be simulated and tested in CI to avoid future regression.

Describe the solution you'd like
Cover with unit tests and integration tests.
@ivelin ivelin added the tests Test coverage label Apr 5, 2021
@ivelin ivelin mentioned this issue Apr 10, 2021
Merged
5 tasks
@stale
Copy link

stale bot commented Oct 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 11, 2021
@ivelin ivelin closed this as completed in 72f72ba Nov 3, 2021
github-actions bot pushed a commit that referenced this issue Nov 3, 2021
@semantic-release-bot
chore(release): 2.21.0
d3bfe8e 
# [2.21.0](v2.20.0...v2.21.0) (2021-11-03)

### Features

* manage multiple edge devices in PWA ([#757](#757)) ([72f72ba](72f72ba)), closes [#758](#758) [#753](#753) [#741](#741) [#711](#711) [#705](#705) [#660](#660) [#659](#659) [#601](#601) [#595](#595) [#589](#589) [#563](#563) [#408](#408) [#370](#370) [#329](#329) [#327](#327) [#302](#302) [#299](#299)
@ivelin
Copy link
Contributor Author

ivelin commented Nov 3, 2021

🎉 This issue has been resolved in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ivelin ivelin added the released label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
released tests Test coverage wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivelin