chore: checkpoint

Signed-off-by: ivelin <[email protected]>
ambianic · Nov 10, 2021 · 39d93e4 · 39d93e4
1 parent 76dc90f
commit 39d93e4
Show file tree

Hide file tree

Showing 4 changed files with 349 additions and 10 deletions.
diff --git a/.gitpod.yml b/.gitpod.yml
@@ -54,6 +54,7 @@ ports:
   - port: 6080 # Cypress Interactive Mode
     onOpen: open-browser
   - port: 3000 # Static file serve via Browsersync
+    onOpen: open-browser
   - port: 3001 # Browsersync dashboard
   - port: 8888 # Dependencies chart
   - port: 10000

diff --git a/src/routes/routes.js b/src/routes/routes.js
@@ -67,6 +67,15 @@ const routes = [
     // which is lazy-loaded when the route is visited.
     component: () => import(/* webpackChunkName: "devicecard" */ '../views/DeviceCard.vue')
   },
+  {
+    path: '/device/notifications/config',
+    name: 'deviceNotificationsConfig',
+    meta: { title: 'Device Notifications Config' },
+    // route level code-splitting
+    // this generates a separate chunk (about.[hash].js) for this route
+    // which is lazy-loaded when the route is visited.
+    component: () => import(/* webpackChunkName: "deviceNotificationsConfig" */ '../views/DeviceNotificationsConfig.vue')
+  },
   {
     path: '/feedback',
     name: 'feedback',

diff --git a/src/views/DeviceCard.vue b/src/views/DeviceCard.vue
@@ -87,18 +87,19 @@
                       :on-submit="onDisplayNameChanged"
                       :rules="[rules.required, rules.counter]"
                     />
-                    <v-list-item> <!-- Notifications list item -->
+                    <v-list-item>
+                      <!-- Notifications list item -->
                       <v-list-item-avatar>
                         <v-icon>
                           mdi-bell-outline
                         </v-icon>
                       </v-list-item-avatar>
                       <v-list-item-content>
-                          <v-switch
-                            v-model="enableNotifications"
-                            :label='`Notifications ${ enableNotifications ? "On" : "Off" }`'
-                            :disabled="!isEdgeConnected"
-                          ></v-switch>
+                        <v-switch
+                          v-model="enableNotifications"
+                          :label="`Notifications ${ enableNotifications ? &quot;On&quot; : &quot;Off&quot; }`"
+                          :disabled="!isEdgeConnected"
+                        />
                       </v-list-item-content>
                       <v-list-item-action
                         v-if="isEdgeConnected"
@@ -138,7 +139,6 @@
                       icon-name="alpha-v-circle-outline"
                       data-cy="list-item-edgeVersion"
                     />
-
                   </v-list>
                 </v-card>
               </v-col>
@@ -342,10 +342,10 @@ export default {
       await this.deleteCurrentDeviceConnection()
       // close forget device dialog
       this.forgetDeviceDialog = false
-      this.$router.replace({ name: 'settings' })
+      await this.$router.replace({ name: 'settings' })
     },
-    notificationsConfigClicked () {
-      // go to device notifications config page
+    async notificationsConfigClicked () {
+      await this.$router.replace({ name: 'deviceNotificationsConfig' })
     }
   },
   computed: {