Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to the latest version of bundler #443

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Jan 24, 2024

Why and what is being done.
This prevents the deprecation warning:

Calling DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call DidYouMean.correct_error(error_name, spell_checker)' instead.

Pre-Merge Checklist

  • CHANGELOG.md updated with short summary

Copy link
Collaborator

@grosser grosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that warning is annoying :D

@grosser
Copy link
Collaborator

grosser commented Jan 24, 2024

needs rebase ... maybe just don't change changelog for this
... PR template can say "... for user facing changes" to be clearer

@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 24, 2024

Rebased and PR template updated.

@grosser
Copy link
Collaborator

grosser commented Jan 24, 2024

2.7 failed ... should be fine to drop it from the matrix and then bump the min ruby version in .rubocop.yml (careful with all the new auto-formattings)

ERROR:  Error installing bundler:
  	There are no versions of bundler (= 2.5.5) compatible with your Ruby & RubyGems
  	bundler requires Ruby version >= 3.0.0. The current ruby version is 2.7.8.[22](https://github.com/ambethia/recaptcha/actions/runs/7643419720/job/20825379372?pr=443#step:3:27)5.

@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 24, 2024

I made #444 to add 3.3 and drop 2.7. After that is merged, I can rebase this.

This prevents the deprecation warning:
> Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.
@jcoyne
Copy link
Contributor Author

jcoyne commented Jan 24, 2024

Okay, this is looking good now.

@grosser grosser merged commit 1a2e59d into ambethia:master Jan 24, 2024
5 of 7 checks passed
@jcoyne jcoyne deleted the update-bundler branch January 24, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants