Remove webpack#866
Closed
faustinoaq wants to merge 28 commits into
Closed
Conversation
…/amber into fa/new-amber-watch-config
…er into fa/new-exception-page
Closed
drujensen
reviewed
Jul 2, 2018
Member
drujensen
left a comment
There was a problem hiding this comment.
Do we want to remove webpack or do we want to remove the dependency? I actually like having webpack included out of the box, but I want the ability to remove/replace it if so desired. wdyt?
| }, | ||
| resolve: { | ||
| alias: { | ||
| amber: path.resolve(__dirname, '../../lib/amber/assets/js/amber.js') |
Member
There was a problem hiding this comment.
We will need to figure out how to include this for anyone using web sockets.
| database: <%= @database %> | ||
| language: <%= @language %> | ||
| model: <%= @model %> | ||
| watch: |
| context.response.print(error.internal_server_error) | ||
| end | ||
| end | ||
| class <%= class_name %> < Amber::Pipe::Error |
Member
There was a problem hiding this comment.
This doesn't seem anything to do with removing web pack.
eliasjpr
approved these changes
Jul 5, 2018
Contributor
eliasjpr
left a comment
There was a problem hiding this comment.
I am confused about this PR in the sense that is Removing something but it adds more 1700+ lines 😕 Other than that Webpack can be 💣
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET!⚠️
This highly depends on #865 and #864
Also please be aware of all the breaking changes
No NPM means, we need to use vanilla JS and plain CSS.
Maybe we can propose a
--npmflag, WDYT?Description of the Change
This PR depends on #865
Alternate Designs
Keep configurable/removable webpack/sass dependency implemented on #865
Benefits
amber.min.jsdependency, see: Update assets #825amber/Dockerfile
Lines 7 to 9 in ddcb6f2
Possible Drawbacks
public/folder,amber watchis using auxiliar tasks withcpandcatcommands