Skip to content

Commit

Permalink
Avoid deadlock with systemctlreload-thispackage and Wants: cloud-fina…
Browse files Browse the repository at this point in the history
…l-which-called-us-to-reload

Wants: and After: do indeed indicate a soft dependency on the existentiality of
a package (cloud-init), but not on the state of whether it has begun running
and finished running. If it exists at all, then After: will

There is no mechanism built-in for either allowing update-motd not to depend on
cloud-init existing, or asking cloud-init to run things that start update-motd
and not hang on cloud-init having finished.
  • Loading branch information
chadmiller-amzn committed Jul 9, 2018
1 parent e5fb657 commit 93ee6b2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions SOURCES/update-motd.service
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
[Unit]
Description=Dynamically Generate Message Of The Day
After=network-online.target cloud-final.service
Wants=cloud-final.service
After=network-online.target

[Service]
Type=oneshot
Expand Down
4 changes: 2 additions & 2 deletions SPECS/update-motd.spec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Name: update-motd
Version: 1.1.1
Release: 2%{?dist}
Version: 1.1.2
Release: 1%{?dist}
License: ASL 2.0
Summary: Framework for dynamically generating MOTD
Group: System Environment/Base
Expand Down

0 comments on commit 93ee6b2

Please sign in to comment.