reader: Add committed_chunk_id/1 callback implementation#47
Merged
the-mikedavis merged 1 commit intomainfrom Feb 3, 2026
Merged
reader: Add committed_chunk_id/1 callback implementation#47the-mikedavis merged 1 commit intomainfrom
the-mikedavis merged 1 commit intomainfrom
Conversation
This adds an implementation for `osiris_log_reader:committed_chunk_id/1` which was added upstream recently in <https://github.com/rabbitmq/osiris/pull/203>. The committed chunk ID is now a different concept than the committed offset. The committed chunk Id is the first offset in the chunk which is committed by a quorum. The committed offset is the last offset in that chunk. Here we do the same as `osiris_log`: read the values which are being maintained in the `osiris_log_shared` atomic.
the-mikedavis
added
C-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an implementation for
osiris_log_reader:committed_chunk_id/1which was added upstream recently in rabbitmq/osiris#203. The committed chunk ID is now a different concept than the committed offset. The committed chunk Id is the first offset in the chunk which is committed by a quorum. The committed offset is the last offset in that chunk.Here we do the same as
osiris_log: read the values which are being maintained in theosiris_log_sharedatomic.I have rebased the branches in Osiris and the server to add this new callback.
Also see rabbitmq/rabbitmq-server#15225
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.