adding end customer authentication apis and events #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiajon
requested review from
doreechi,
sainapra and
mhiaror
and removed request for
a team
mhiaror
reviewed
Jan 2, 2025
| chatSession.onAuthenticationInitiated(event => { | ||
| const eventDetails = data?.data; | ||
| try { | ||
| content = JSON.parse(eventDetails?.Content); |
There was a problem hiding this comment.
QQ. Why we did not parse the response within ChatJs and exposed a type ?
mhiaror
approved these changes
Jan 2, 2025
xiajon
commented
Jan 2, 2025
| * Subscribes an event handler that triggers when the session is lost. | ||
| * @param handler The event handler. | ||
| */ | ||
| onConnectionLost(handler: (event: ChatTypingEvent) => void): void; |
There was a problem hiding this comment.
removed duplicate conflicting event handler https://github.com/amazon-connect/amazon-connect-chatjs/blob/master/src/index.d.ts#L267
| @@ -903,14 +1043,6 @@ declare namespace connect { | |||
| readonly CUSTOMER_MANAGED: "CUSTOMER_MANAGED"; | |||
| } | |||
|
|
|||
| /** Enumerates the log levels. */ | |||
| interface ChatLogLevel { | |||
There was a problem hiding this comment.
mhiaror
approved these changes
Jan 2, 2025
mrajatttt
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adding end customer authentication API and lifecycle events. Upgrading aws sdk v2 to v3