Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove hardcoded waveform names #616

Merged
merged 3 commits into from
Aug 26, 2024
Merged

remove hardcoded waveform names #616

merged 3 commits into from
Aug 26, 2024

Conversation

yitchen-tim
Copy link
Contributor

@yitchen-tim yitchen-tim commented Aug 26, 2024 •
edited
Loading

Description of changes:

  • Remove hardcoded waveform names in notebooks
  • Use qubit 3 in the example instead of qubit 4 (qubit 4 has low quality at the date notebook is run)
  • Ignore pulse notebooks in integ tests to avoid further issue due to device quality

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@yitchen-tim yitchen-tim marked this pull request as ready for review August 26, 2024 18:32
@yitchen-tim yitchen-tim requested a review from a team as a code owner August 26, 2024 18:32
@yitchen-tim yitchen-tim merged commit ef40edb into main Aug 26, 2024
8 checks passed
@yitchen-tim yitchen-tim deleted the yitchen/remove-waveform-name branch August 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@speller26 speller26 speller26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yitchen-tim @speller26