Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PennyLane OQC Lucy demo #448

Merged
merged 21 commits into from
Feb 15, 2024
Merged

Add PennyLane OQC Lucy demo #448

merged 21 commits into from
Feb 15, 2024

Conversation

Qottmann
Copy link
Contributor

@Qottmann Qottmann commented Nov 6, 2023

Adding our recent PennyLane demo for accessing OQC's Lucy device with pulse level control via PennyLane through braket.

@Qottmann Qottmann requested a review from a team as a code owner November 6, 2023 12:51
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

christianbmadsen
christianbmadsen reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@christianbmadsen christianbmadsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this contribution @Qottmann! I have left a first round of feedback for you to address.

@Qottmann
Copy link
Contributor Author

Thanks for the review @christianbmadsen
Will re-run the notebook in the uptime window of Lucy with the added cost tracker, great suggestion!

@Qottmann
Copy link
Contributor Author

Updated version with tracker and changes from code review now online ✅

@Qottmann
Copy link
Contributor Author

Can we bump the version of pennylane-braket plugin to latest v1.23 and pennylane to >= 0.32?

@math411
Copy link
Contributor

math411 commented Dec 11, 2023

Can we bump the version of pennylane-braket plugin to latest v1.23 and pennylane to >= 0.32?

Hi @Qottmann, the versions are raised to Pennylane==0.33.1 and amazon-braket-pennylane-plugin==1.23.0. Merging from main should get you the new requirements.txt with this update.

@jcjaskula-aws jcjaskula-aws self-assigned this Feb 6, 2024
jcjaskula-aws
jcjaskula-aws previously approved these changes Feb 14, 2024
View reviewed changes
@jcjaskula-aws jcjaskula-aws merged commit 6ddbb68 into amazon-braket:main Feb 15, 2024
8 checks passed
@Qottmann
Copy link
Contributor Author

Thanks! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbmadsen christianbmadsen christianbmadsen left review comments

@laurencap laurencap laurencap left review comments

@krneta krneta krneta approved these changes

@jcjaskula-aws jcjaskula-aws jcjaskula-aws approved these changes

Assignees

@jcjaskula-aws jcjaskula-aws

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Qottmann @math411 @christianbmadsen @krneta @jcjaskula-aws @laurencap