Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow None as default value for Any type hint #22

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

rmshaffer
Copy link
Contributor

Issue #, if available:
#21

Description of changes:
Allow None as a default value for a parameter with type hint of Any.

Testing done:
Existing test case expanded to cover new functionality.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ce26c13) to head (7803a76).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          339       339           
  Branches       103       103           
=========================================
  Hits           339       339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer rmshaffer marked this pull request as ready for review April 2, 2024 15:38
@rmshaffer rmshaffer requested a review from krneta May 21, 2024 20:25
@rmshaffer rmshaffer requested a review from speller26 June 27, 2024 22:45
@speller26 speller26 merged commit 66c0395 into main Jun 28, 2024
11 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/fix-21 branch June 28, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: error when parameter with type hint Any has a default value of None
2 participants