update: add binary operators in type hints (new in 3.10) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
===========================================
+ Coverage 97.81% 100.00% +2.18%
===========================================
Files 2 2
Lines 320 326 +6
Branches 95 97 +2
===========================================
+ Hits 313 326 +13
+ Misses 2 0 -2
+ Partials 5 0 -5
☔ View full report in Codecov by Sentry. |
ajberdy
previously approved these changes
Oct 17, 2023
krneta
changed the title
ajberdy
reviewed
Oct 18, 2023
| arg3 (int): This is yet another parameter | ||
| Returns: | ||
| int: value of the function. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
nit: newline. Looks unrelated to this change though. Does this package not get linted by itself or does it not check for newlines?
There was a problem hiding this comment.
Not for the example files we use for testing. They have errors on purpose.
There was a problem hiding this comment.
Oh right, that makes sense lol
ajberdy
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.