Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude precompilation from coverage #6

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Exclude the precompilation files from coverage -- these aren't exercised by tests, because they are only run at package install.

Testing done: Unit tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kshyatt-aws kshyatt-aws requested a review from a team as a code owner April 29, 2024 16:55
Copy link

codecov bot commented Apr 29, 2024

The author of this PR, kshyatt-aws, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@krneta
Copy link
Contributor

krneta commented Apr 29, 2024

Is there a way to exclude file patterns (like */precompile.jl) ?

@kshyatt-aws
Copy link
Member Author

Not sure if there's an easy way in the GH action.

@kshyatt-aws kshyatt-aws merged commit f82d848 into main Apr 29, 2024
10 checks passed
@kshyatt-aws kshyatt-aws deleted the ksh/precmopile_cov branch April 29, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants