Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: adding codescan analysis #3

Merged
merged 6 commits into from
Apr 30, 2024
Merged

update: adding codescan analysis #3

merged 6 commits into from
Apr 30, 2024

Conversation

krneta
Copy link
Contributor

@krneta krneta commented Apr 25, 2024

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@krneta krneta requested a review from a team as a code owner April 25, 2024 20:22
@@ -0,0 +1,18 @@
name: Codacy Security Scan
Copy link

@virajvchaudhari virajvchaudhari Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why this security scan tool?
  2. Is this approved by AWS open-source/security team?
  3. Where does this publish results to and what types of results does it publish? Is it in the repository itself or somewhere else?

@krneta krneta changed the title update: adding codacy analysis update: adding codescan analysis Apr 25, 2024
Copy link

codecov bot commented Apr 26, 2024

The author of this PR, krneta, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@kshyatt-aws
Copy link
Member

Are we good to go with this?

@krneta
Copy link
Contributor Author

krneta commented Apr 29, 2024

I think so. I need an approval.

@krneta krneta merged commit 3268d6e into main Apr 30, 2024
11 checks passed
@krneta krneta deleted the codescan branch April 30, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants