Make shifting Fields or local Detunings optional. Add tests. #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshyatt-aws
reviewed
Aug 12, 2024
src/mps_utils.jl
Outdated
|
|
||
| n_atoms = length(ahs_program["setup"]["ahs_register"]["sites"]) | ||
| # Supporting both localDetuning and shiftingFields naming conventions | ||
| loc_detuning_key = "" |
There was a problem hiding this comment.
Why not
loc_detuning_key = if "shiftingFields" ∈ keys(ahs_program["hamiltonian"])
"shiftingFields"
elseif "localDetuning" ∈ keys(ahs_program["hamiltonian"])
"localDetuning"
end
kshyatt-aws
reviewed
Aug 12, 2024
src/mps_utils.jl
Outdated
| end | ||
|
|
||
| # Check if local detuning or shifting fields were found, otherwise assign zeros | ||
| if !isempty(loc_detuning_key) |
There was a problem hiding this comment.
I think you can simplify this with Base.get
kshyatt-aws
reviewed
Aug 12, 2024
test/runtests.jl
Outdated
| @@ -2,7 +2,7 @@ using BraketAHS: run, save_results | |||
| using Test | |||
| using JSON3 | |||
|
|
|||
| @testset "BraketAHS.jl" begin | |||
| @testset "BraketAHS.jl: Non-empty local detunings" begin | |||
| # Write your tests here. | |||
There was a problem hiding this comment.
Maybe we can get rid of this comment lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Resolving Issue #22 *
Description of changes:
localDetuningandshiftingFieldsas input fields in AHS program JSON.localDetuningorshiftingFieldsfield