Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Any plans for updating to angular 6? #139

Closed
richardsengers opened this issue Apr 17, 2018 · 1 comment
Closed

Any plans for updating to angular 6? #139

richardsengers opened this issue Apr 17, 2018 · 1 comment

Comments

@richardsengers
Copy link

richardsengers commented Apr 17, 2018

Hi, I've updated my project to the latest release candidate of Angular 6 and Angular cli 6 but this breaking change: angular/angular-cli#9827 (comment)
is causing AWS Cognito library to fail

The problem with net/global is not so straightforward. We are removing it for 6.x, yes (#9812). And we do expect this to cause problems to some projects. But we're not doing it because we want to break projects, we're doing it because leaving it in also breaks other projects, and it is incorrect.

The incorrect part is libraries that are meant to run in the browser relying on node globals being available. Browser code runs in the browser, not in node, and shouldn't expect things that are not available in a browser context to be there.

So when you serve an Angular 6 project with AWS Cognito you are getting an error "Uncaught ReferenceError: global is not defined" in Buffer.js

@richardsengers
Copy link
Author

richardsengers commented Apr 18, 2018

Closing in favor of aws-amplify/amplify-js#678

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant