Skip to content

Commit

Permalink
[Minor] Change aliase to alias (apache#6386)
Browse files Browse the repository at this point in the history
### What changes were proposed in this pull request?

The singular of aliases is alias not aliase.

### Why are the changes needed?

See above.

Fix: #N/A

### Does this PR introduce _any_ user-facing change?

Yes, as it's a UI change.

### How was this patch tested?

locally.
  • Loading branch information
justinmclean authored Feb 3, 2025
1 parent 09d4e64 commit 342a666
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/webui.md
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ Click on the `LINK VERSION` button displays the dialog to link a version.
Link a version needs these fields:

1. **URI**(**_required_**): the uri of the version.
2. **Aliases**(**_required_**): the aliases of the version, aliase cannot be number or number string.
2. **Aliases**(**_required_**): the aliases of the version, an alias cannot be a number or number string.
3. **Comment**(_optional_): the comment of the model.
4. **Properties**(_optional_): Click on the `ADD PROPERTY` button to add custom properties.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ const schema = yup.object().shape({
yup.object().shape({
name: yup
.string()
.required('This aliase is required')
.test('not-number', 'Aliase cannot be a number or numeric string', value => {
.required('The alias is required')
.test('not-number', 'Alias cannot be a number or a numeric string', value => {
return value === undefined || isNaN(Number(value))
})
})
)
.test('unique', 'Aliase must be unique', (aliases, ctx) => {
.test('unique', 'Alias must be unique', (aliases, ctx) => {
const values = aliases?.filter(a => !!a.name).map(a => a.name)
const duplicates = values.filter((value, index, self) => self.indexOf(value) !== index)

Expand All @@ -81,7 +81,7 @@ const schema = yup.object().shape({

return ctx.createError({
path: `aliases.${duplicateIndex}.name`,
message: 'This aliase is duplicated'
message: 'This alias is duplicated'
})
}

Expand Down Expand Up @@ -326,7 +326,7 @@ const LinkVersionDialog = props => {
field.onChange(event)
trigger('aliases')
}}
label={`Aliase ${index + 1}`}
label={`Alias ${index + 1}`}
error={!!errors.aliases?.[index]?.name || !!errors.aliases?.message}
helperText={errors.aliases?.[index]?.name?.message || errors.aliases?.message}
fullWidth
Expand Down

0 comments on commit 342a666

Please sign in to comment.