Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Queue & Stack #104

Merged
merged 5 commits into from
Oct 1, 2020
Merged

[JavaScript] Queue & Stack #104

merged 5 commits into from
Oct 1, 2020

Conversation

Rajdeepc
Copy link
Contributor

@Rajdeepc Rajdeepc commented Oct 1, 2020

Created a fresh PR with all suggested changes. Kindly review.

Copy link
Owner

@amanmehara amanmehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename directory JavaScript - Queue to Queue and JavaScript - Stack to Stack.

Comment on lines 1 to 5
/**
* Year: 2020
* Copyright: Rajdeep Chandra
* License: https://www.apache.org/licenses/LICENSE-2.0
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* Year: 2020
* Copyright: Rajdeep Chandra
* License: https://www.apache.org/licenses/LICENSE-2.0
*/
// Copyright 2020 Rajdeep Chandra
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Comment on lines 1 to 5
/**
* Year: 2020
* Copyright: Rajdeep Chandra
* License: https://www.apache.org/licenses/LICENSE-2.0
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**
* Year: 2020
* Copyright: Rajdeep Chandra
* License: https://www.apache.org/licenses/LICENSE-2.0
*/
// Copyright 2020 Rajdeep Chandra
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed

Copy link
Owner

@amanmehara amanmehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 🎉

@amanmehara amanmehara changed the title Added Stack and Queue Algorithm implementations in JavaScript Category [JavaScript] Queue & Stack Oct 1, 2020
@amanmehara amanmehara merged commit eb82271 into amanmehara:master Oct 1, 2020
@Rajdeepc
Copy link
Contributor Author

Rajdeepc commented Oct 4, 2020

@amanmehara Can you please label this PR as hacktoberfest-accepted. This PR is not labelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants