Skip to content

added fixes for pending comments #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kishanio merged 1 commit into from
Sep 14, 2022
Merged

added fixes for pending comments #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions imagekitio/file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,9 @@ def create_folder(
"""Create folder by provided folderName and parentFolderPath as an options"""
url = "{}/v1/folder".format(URL.API_BASE_URL)
headers = self.request.create_headers()
headers.update({"Content-Type": "application/json"})
formatted_data = (
request_formatter(options.__dict__) if options is not None else dict()
dumps(request_formatter(options.__dict__)) if options is not None else dict()
)
resp = self.request.request(
method="Post", url=url, headers=headers, data=formatted_data
Expand All @@ -484,8 +485,9 @@ def delete_folder(
"""Delete folder by provided folderPath as an options"""
url = "{}/v1/folder".format(URL.API_BASE_URL)
headers = self.request.create_headers()
headers.update({"Content-Type": "application/json"})
formatted_data = (
request_formatter(options.__dict__) if options is not None else dict()
dumps(request_formatter(options.__dict__)) if options is not None else dict()
)
resp = self.request.request(
method="Delete", url=url, headers=headers, data=formatted_data
Expand Down
4 changes: 2 additions & 2 deletions tests/test_folder_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def test_create_folder_succeeds(self):
)
self.assertEqual("http://test.com/v1/folder", responses.calls[0].request.url)
self.assertEqual(
"folderName=folder_name&parentFolderPath=%2Ftest",
'{"folderName": "folder_name", "parentFolderPath": "/test"}',
responses.calls[0].request.body,
)

Expand Down Expand Up @@ -169,7 +169,7 @@ def test_delete_folder_succeeds(self):
resp.response_metadata.__dict__,
)
self.assertEqual("http://test.com/v1/folder", responses.calls[0].request.url)
self.assertEqual("folderPath=%2FfolderName", responses.calls[0].request.body)
self.assertEqual('{"folderPath": "/folderName"}', responses.calls[0].request.body)


class TestCopyFolder(ClientTestCase):
Expand Down