Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include version information in module descriptor #253

Closed
wants to merge 1 commit into from
Closed

Include version information in module descriptor #253

wants to merge 1 commit into from

Conversation

sormuras
Copy link

@sormuras sormuras commented Nov 7, 2021

Although a local test via mvn verify failed with...

[ERROR] Failed to execute goal pw.krejci:multi-release-jar-maven-plugin:0.1.5:compile (default-compile) on project streamex: Failed to prepare multi-release sources for staged compilation.: Destination '/workspaces/streamex/target/sources-9/descriptor/module-info.java' already exists -> [Help 1]

...this should do the trick. If not, either @metlos might help here with pointing to the right location to configure the extended maven-compiler-plugin ... or adding an additional invocation of Java's jar --update --file ... --module-version is the way.

@amaembo
Copy link
Owner

amaembo commented Nov 20, 2021

It looks like it started working automagically when I migrated to a newer maven-compiler-plugin and got rid of multi-release-jar-maven-plugin. At least, now I see the version in decompiler:

\streamex\target\classes\META-INF\versions\9>javap module-info.class
Compiled from "module-info.java"
module [email protected] {
  requires java.base;
  exports one.util.streamex;
}

Nevertheless thanks for the help!

@sormuras
Copy link
Author

That's even better - you're welcome!

@sormuras sormuras deleted the include-version-in-module branch November 20, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants