Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI code also sets some settings:
However we can't easily make changes to these, since it'll depend on the customer updating their version of the CLI. This can cause issues when the CLI and passive snippet make assumptions about their configuration options or defaults and get out of sync. Therefore maybe we should move to:
And then we set the CLI defaults within the snippet. Eventually we could publish separate snippets for passive vs manual, and so reduce the size of the passive snippet.
This PR moves in this direction (CLI settings for snippet set in snippet not in CLI), and also disables rrweb recording in the passive snippet. This is because rrweb often produces > 2mb of data, which causes the session to be abandoned.