Skip to content

Conversation

@MattIPv4
Copy link
Member

Describe your changes

Node.js v24 is now the active LTS line with the v24.11.0 release.

Also, this bumps us to the latest pnpm version while we're here.

Notes for testing your change

Ensure Vercel is actually running 24.11.0 or newer.

@vercel
Copy link

vercel bot commented Oct 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
alveusgg-website Ready Ready Preview Dec 3, 2025 10:05pm

@MattIPv4
Copy link
Member Author

MattIPv4 commented Oct 30, 2025

So, looks like setting engines.node inside the website's package.json is the right setting to override the default Node.js version for the Vercel project... but Vercel doesn't support 24.x yet, and so it's just erroring out (stating that 24.x is invalid, rather than trying to use 22.x prior to this commit and failing on the strict engines check in the root package.json)

Skipping build cache since Node.js version changed from "22.x" to ""

Found invalid Node.js Version: "24.x". Please set "engines": { "node": "22.x" } in your `package.json` file to use Node.js 22.

@pjeweb
Copy link
Member

pjeweb commented Dec 3, 2025

Node v24.x should be supported on vercel now: https://vercel.com/changelog/node-js-24-lts-is-now-generally-available-for-builds-and-functions

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the project to use Node.js v24 (now the active LTS) and pnpm v10.20, ensuring the project stays current with modern tooling. The update affects version specifications across multiple configuration files and dependencies.

Key Changes:

  • Updated Node.js from v22 to v24 across all configuration files (.nvmrc, package.json, Dockerfile)
  • Updated pnpm from v10.11.1 to v10.20.0 with exact version pinning
  • Updated @types/node dependency from v22.19.1 to v24.10.1 across all packages
  • Added engine-strict enforcement to .npmrc to ensure correct versions are used
  • Updated Next.js peer dependency constraint from ^15.0 to ^16.0

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updated root engines to require Node.js >=24.11.0 and pnpm ^10.20.0, and set packageManager to exact [email protected]
.nvmrc Updated Node.js version from v22 to v24 for version managers
.npmrc Added engine-strict=true to enforce version requirements
apps/website/package.json Added engines field with Node.js 24.x constraint and updated @types/node to v24.10.1
apps/chatbot/package.json Updated @types/node to v24.10.1
apps/chatbot/Dockerfile Updated base image from node:22-alpine to node:24-alpine
apps/database/package.json Updated @types/node to v24.10.1
apps/donations/worker/package.json Updated @types/node to v24.10.1
pnpm-workspace.yaml Updated Next.js peer dependency allowedVersion from ^15.0 to ^16.0
pnpm-lock.yaml Lockfile regenerated with new Node.js v24 types and updated dependency resolution graph
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MattIPv4 MattIPv4 marked this pull request as ready for review December 3, 2025 21:00
@MattIPv4 MattIPv4 requested a review from a team as a code owner December 3, 2025 21:00
@pjeweb
Copy link
Member

pjeweb commented Dec 3, 2025

@MattIPv4 Can you take a look at #1693 - this removes the webcrypto import completely and narrows the (now generic - thats with es2024/ts 5.7) UInt8Array to be ArrayBuffer based and not allow SharedArrayBuffer.

Use global (web) crypto instead of importing, narrow types
Copilot AI review requested due to automatic review settings December 3, 2025 22:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MattIPv4 MattIPv4 merged commit 2271b66 into main Dec 3, 2025
11 checks passed
@MattIPv4 MattIPv4 deleted the MattIPv4/node-js-24 branch December 3, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants