Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watch new pods created during measures #5

Merged
merged 4 commits into from
Jun 20, 2024
Merged

Watch new pods created during measures #5

merged 4 commits into from
Jun 20, 2024

Conversation

AngeCyp
Copy link
Contributor

@AngeCyp AngeCyp commented May 28, 2024

Added a way to watch creation and deletion of pods.
Using inotify crate to add a watch on directories used by Kubernetes

TheElectronWill
TheElectronWill requested changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@TheElectronWill TheElectronWill left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work, but I'm wondering whether this is the best approach to the problem.
Also, you need to replace all println! by log::<something> calls.

plugin-k8s/src/lib.rs Outdated Show resolved Hide resolved
plugin-k8s/src/lib.rs Outdated Show resolved Hide resolved
plugin-k8s/Cargo.toml Outdated Show resolved Hide resolved
plugin-k8s/src/k8s_probe.rs Outdated Show resolved Hide resolved
plugin-k8s/src/k8s_probe.rs Outdated Show resolved Hide resolved
plugin-k8s/src/k8s_probe.rs Outdated Show resolved Hide resolved
TheElectronWill
TheElectronWill requested changes Jun 12, 2024
View reviewed changes
plugin-k8s/src/cgroup_v2.rs Outdated Show resolved Hide resolved
plugin-k8s/src/lib.rs Outdated Show resolved Hide resolved
plugin-k8s/src/lib.rs Show resolved Hide resolved
plugin-k8s/src/lib.rs Outdated Show resolved Hide resolved
plugin-k8s/src/parsing_cgroupv2.rs Outdated Show resolved Hide resolved
@TheElectronWill TheElectronWill mentioned this pull request Jun 12, 2024
Closed
@TheElectronWill TheElectronWill self-requested a review June 17, 2024 09:22
TheElectronWill
TheElectronWill approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@TheElectronWill TheElectronWill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good

@TheElectronWill TheElectronWill merged commit 76a6793 into main Jun 20, 2024
2 checks passed
@TheElectronWill TheElectronWill deleted the feature/detect-new-pod branch June 20, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheElectronWill TheElectronWill TheElectronWill approved these changes

Assignees

@AngeCyp AngeCyp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngeCyp @TheElectronWill