-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/source site polymorphism #115
Feature/source site polymorphism #115
Conversation
…iverse parser (not used yet)
…e multiple sources, so that we can represent mirrors and duplicates.
…se migrations in future.
…erything to AsNoTracking.
ee66307
to
6e6a673
Compare
b4e7518
to
288328f
Compare
… whose performance is terrible.
…ge of creator details.
Works:
Polish follow-ups (probably do after merging to not make this PR any bigger):
|
… than the API one.
…epped the problem)
Opened #119 for figuring out the future of Mini.Link, #120 to go through and clean-up Gumroad and MyMiniFactory websites once we merge and deploy all this. Just pushed a fix for some MyMiniFactory issues I was seeing. I still saw some duplicated SourceSites for MyMiniFactory, but I'm not sure if that was due to me messing up the DB, the SourceSite itself, or the submission handler. I'm going to reset the PPE DB to a recent backup to check. |
…h CreatorUserName and SitName. However currentSource.Site.SiteName is always blank for some reason...
…to fix up "Website" sources that are actually MyMiniFactory
Did a diff of the production and preproduction databases to figure out more about #119, it looks like MiniSourceSite.Link is NULL for all Gumroad Minis that were in the db pre-migration. Query:
MSS.Link should never be NULL, but is NULL for all Gumroad links |
Only remaining open issues I have in my head right now:
I'll try to do another thorough test pass in the next day or so. |
The reason that adding a mini from a creator's page doesn't work is because it's making a GET request; technically speaking a GET shouldn't have side effects like creating things in the database. One simple way to make this work would be to make the button a form submit so that it can POST instead. |
…to a form submission so that it can hit the POST endpoint. Seems to work.
Addresses #58
Lays some groundwork for #47
Should streamline the process of adding new supported sources for minis.