Fix install test and uncap kaleido #4423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4423 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 352 352
Lines 39805 39804 -1
=======================================
+ Hits 39682 39683 +1
+ Misses 123 121 -2 ☔ View full report in Codecov by Sentry. |
This reverts commit de35257.
MichaelFu512
force-pushed
the
install_test_fix
branch
from
abaf00d to
34996d5
Compare
| "--single-process", | ||
| "--headless", | ||
| "--disable-gpu", | ||
| ) |
There was a problem hiding this comment.
Originally these were only meant for mac m1 tests to pass, but windows tests also needs these settings for testing, else some tests hang forever, causing workers to fail.
| - name: Install evalml from sdist (using cache) | ||
| if: steps.cache.outputs.cache-hit == 'true' | ||
| run: | | ||
| python -m pip install "unpacked_sdist/." --no-deps |
There was a problem hiding this comment.
Whenever the install_tests would use cache, the test would fail.
There was a problem hiding this comment.
Interesting, do you think it's noticably slower since we're not using the cache? If so, by how much?
There was a problem hiding this comment.
Interestingly the time it takes varies.
The latest commit (2b11a69) has the time that ubuntu takes for this step to be 8 seconds. For MacOS it takes 40 seconds for python3.9 and 3 minutes for python3.11.
Conversely, the second latest commit (cd3f4f8) has the time that ubuntu takes hover around 1 minute. MacOS hovers at around 40 seconds.
I can't say for sure how much slower it is without cache because it didn't work with cache enabled. I can go test to see if I can get cache working (hopefully it doesn't erase the approvals).
There was a problem hiding this comment.
FWIW, I was having trouble with caches in other OS repos recently and ended up removing them because they were failing too often.
MichaelFu512
changed the title
| - name: Install evalml from sdist (using cache) | ||
| if: steps.cache.outputs.cache-hit == 'true' | ||
| run: | | ||
| python -m pip install "unpacked_sdist/." --no-deps |
There was a problem hiding this comment.
Interesting, do you think it's noticably slower since we're not using the cache? If so, by how much?
MichaelFu512
changed the title
4 participants
Pull Request Description
Closes #4420 and Closes #4394
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.