Added support for truecolor Neovim and for the Neovim terminal #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added color bindings for the Neovim terminal, based on the gnome-terminal bindings. Closes altercation#293. You'll need to set the env var $NVIM_TUI_ENABLE_TRUECOLOR to 1
|
This should be merged. |
|
This absolutely should be merged! |
mcmire
added a commit
to mcmire/vimfiles
that referenced
this pull request
Apr 12, 2018
The Solarized color scheme for Vim doesn't use RGB colors in the terminal, only in MacVim/gVim. However, iTerm supports RGB colors. There's an open pull request that turns this on[1], but it hasn't been merged in. Instead of pulling this plugin from GitHub, simply vendor it. [1]: altercation/solarized#329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced several calls to
has('gui_running')with a function to check if we're running in Neovim and, if so, check if it can use truecolor.The colors for Neovim's
:terminalwere matched up to the ones forgnome-terminal