-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A custom DISPLAY to determinate the socket_path. #196
base: master
Are you sure you want to change the base?
Conversation
The socket reconnection support added. |
Will conflict with #199 Did the current version create errors or is this a "nice to have" thing? |
Hi, It's easier to connect to many i3 servers with this PR. Similar to If you accept #199, I could refactor this PR to avoid using if self._display:
env = {**os.eviron, 'DISPLAY': self._display}
else:
env = None
process = run([binary, '--get-socketpath'], stdout=PIPE, stderr=PIPE, env=env) That's all what I need. |
Great clarification, thanks :) I'm unfortunately not the package maintainer for this project, wish I was though. Just emailed the maintainer asking what's up and if I could help out. I'm thinking about creating a fork of this project since it feels unmaintained, but I'll see if he replies first. We'll just have to wait. So it's up to you if you want to preemptively do the refactor before that :) |
👋 looking at this now |
Add `display` argument to sync and async `Connetion()` classes to determineate the socket_path. Useful when you work with many Xephyr servers.
Search the socket path on reconnect if no user's socket_path defined.
85fe1f9
to
dd05c13
Compare
Add
display
argument to sync and asyncConnetion()
classesto determineate the socket_path. Useful when you work with many
Xephyr servers.