This repository was archived by the owner on Apr 9, 2024. It is now read-only.
update for latest selenium#106
Closed
PaleNeutron wants to merge 1 commit into
Closed
Conversation
|
@jakevdp what is needed to merge in these updates? if there are tests or other things that are needed I'd be happy to help. |
|
hi @jakevdp, do you happen to know if we can merge this in, tested locally seems fine and minor fix |
|
It would be fantastic to get this merged 🚀 |
|
@PaleNeutron Just curious, are there plans to support selenium >=4.30 or is this done in another PR? |
Author
|
@fleimgruber, No, but I think this library will be deprecated in the feature since https://github.com/vega/vl-convert is a much better alternative. |
|
I see, thanks for the heads up and the link! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find_element_by_id type methods are removed from
seleniumscience version4.30