custom type: check for optional

alta · Sep 27, 2021 · f3650d0 · f3650d0
1 parent 5733dfd
commit f3650d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/patch/field_type.go b/patch/field_type.go
@@ -43,6 +43,11 @@ func (p *Patcher) patchTypeDef(id *ast.Ident, obj types.Object) {
 				return true
 			}
 			return false
+		case *ast.StarExpr:
+			t.X = &ast.Ident{
+				Name: fieldType,
+			}
+			return true
 		default:
 			return false
 		}

diff --git a/patch/patcher.go b/patch/patcher.go
@@ -320,7 +320,7 @@ func (p *Patcher) scanField(f *protogen.Field) {
 		switch {
 		case f.Message != nil && !f.Desc.IsList():
 			log.Printf("Warning: type declared for message field: %s", f.Desc.Name())
-		case f.Oneof != nil:
+		case f.Oneof != nil && !f.Desc.HasOptionalKeyword():
 			p.Type(ident.WithChild(f.GoIdent, f.GoName), fieldType)
 			p.Type(ident.WithChild(m.GoIdent, "Get"+f.GoName), fieldType)
 		default: