Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap and other library dependencies #741

Open
wants to merge 84 commits into
base: main
Choose a base branch
from

Conversation

rohandebsarkar
Copy link
Collaborator

This PR is an attempt to move al-folio from Bootstrap v4 to v5. Bootstrap v5 introduced a number of breaking changes, most of them are listed here: https://getbootstrap.com/docs/5.0/migration/.

I have tried to solve most of the breaking changes, but there might be many more that went unnoticed.

Along with bootstrap, I have also updated the other library dependencies to major versions only. This will help in less maintenance of the library versions. And therefore also had to remove the integrity checks. (Also, since we are using a constant major version, there won't be any breaking changes according to SemVer)

I have deployed this branch on Vercel for monitoring any abnormalities. This branch will be continuously deployed on this URL: https://alfolio.vercel.app/

@@ -19,7 +19,7 @@ lang: en # the language of your site (for example: en, fr, cn, ru, etc.)
icon: ⚛️ # the emoji used as the favicon (alternatively, provide image name in /assets/img/)

url: https://alshedivat.github.io # the base hostname & protocol for your site
baseurl: /al-folio # the subpath of your site, e.g. /blog/
# baseurl: /al-folio # the subpath of your site, e.g. /blog/
Copy link
Collaborator Author

@rohandebsarkar rohandebsarkar Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed baseurl since it is causing some problems while deploying this branch on Vercel. I will revert this change before merging this PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# baseurl: /al-folio # the subpath of your site, e.g. /blog/
baseurl: /al-folio # the subpath of your site, e.g. /blog/

Has to be done before merging.

@alshedivat alshedivat added this to the al-folio 1.0 milestone Jul 4, 2022
@stale
Copy link

stale bot commented Dec 17, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 17, 2022
rohandebsarkar added a commit to rohandebsarkar/al-folio that referenced this pull request Jan 1, 2023
Squashed commit of the following:

commit e036baf
Author: Rohan Deb Sarkar <[email protected]>
Date:   Sun Jan 1 14:31:41 2023 +0530

    Fix Altmetric badges

commit 970bad8
Merge: 7fe570d 69e013b
Author: Rohan Deb Sarkar <[email protected]>
Date:   Sun Jan 1 13:34:22 2023 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 7fe570d
Merge: 3f23bd3 5f3c487
Author: rohandebsarkar <[email protected]>
Date:   Mon Oct 17 12:58:30 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 3f23bd3
Author: rohandebsarkar <[email protected]>
Date:   Thu Oct 13 15:59:54 2022 +0530

    move teaching to dropdown menu

commit 9b05ef0
Author: rohandebsarkar <[email protected]>
Date:   Thu Oct 13 15:59:40 2022 +0530

    fix theme change icon width

commit e0e8cef
Merge: 1bd8267 7d7567e
Author: rohandebsarkar <[email protected]>
Date:   Thu Oct 13 15:29:41 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 1bd8267
Author: rohandebsarkar <[email protected]>
Date:   Mon Aug 29 18:50:32 2022 +0530

    update mdb version

commit 63a1bf7
Author: rohandebsarkar <[email protected]>
Date:   Tue Aug 16 18:33:27 2022 +0530

    fix publications badge color

commit 2320adc
Author: rohandebsarkar <[email protected]>
Date:   Mon Aug 15 20:41:15 2022 +0530

    fix mdbootstrap script loading

commit 73aa4f2
Merge: e1ed167 c142853
Author: rohandebsarkar <[email protected]>
Date:   Mon Aug 15 08:44:00 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit e1ed167
Merge: ccac0d8 a36d7f5
Author: rohandebsarkar <[email protected]>
Date:   Sun Aug 7 10:51:21 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit ccac0d8
Merge: 20125e3 4817639
Author: rohandebsarkar <[email protected]>
Date:   Thu Jul 28 21:57:19 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 20125e3
Merge: 1e64134 f618757
Author: rohandebsarkar <[email protected]>
Date:   Sun Jul 24 22:49:10 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 1e64134
Author: rohandebsarkar <[email protected]>
Date:   Sat Jul 16 10:36:04 2022 +0530

    Update `sr-only` to `visually-hidden`

commit 8fce0bb
Author: rohandebsarkar <[email protected]>
Date:   Fri Jul 15 21:02:01 2022 +0530

    fix dropdown border radius

commit c1904f8
Author: rohandebsarkar <[email protected]>
Date:   Wed Jul 13 11:35:22 2022 +0530

    cv margin bottom

commit 44696e6
Author: rohandebsarkar <[email protected]>
Date:   Wed Jul 13 11:20:38 2022 +0530

    typo

commit ed883fc
Merge: 271567f 1ac9b7c
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 12 17:26:21 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 271567f
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 22:39:40 2022 +0530

    Update card spacing

commit 8c28c98
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 22:33:31 2022 +0530

    fix spacing publication links

commit ed7ac19
Merge: e939946 24a5084
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 22:11:44 2022 +0530

    Merge remote-tracking branch 'upstream/master' into update-bootstrap

commit e939946
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 22:10:22 2022 +0530

    fix blog paginantion bg color

commit 9564dd9
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 22:00:28 2022 +0530

    fix dropdown focus bg color

commit 27ba43b
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 11:19:47 2022 +0530

    move canonical url to metadata

commit 80d027c
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 11:15:07 2022 +0530

    made material design optional

commit 6a6c6a1
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 11:05:19 2022 +0530

    fix space

commit 436e3aa
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 10:52:38 2022 +0530

    fix header title

commit 263d11b
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 10:49:05 2022 +0530

    enable tooltips

commit 2f2573b
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 10:47:42 2022 +0530

    Add option for material design and update MDBootstrap

commit 4811a10
Merge: 2f1ea24 edd9fb7
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 11 10:41:12 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 2f1ea24
Author: rohandebsarkar <[email protected]>
Date:   Sun Jul 10 09:02:01 2022 +0530

    sorry, fix badge again agian again

commit 323217f
Author: rohandebsarkar <[email protected]>
Date:   Sun Jul 10 08:28:55 2022 +0530

    fix badge again again

commit 7d8ed94
Author: rohandebsarkar <[email protected]>
Date:   Sun Jul 10 08:12:39 2022 +0530

    fix badge again

commit 511b969
Author: rohandebsarkar <[email protected]>
Date:   Sun Jul 10 07:51:02 2022 +0530

    fix badge

commit 7b59dfd
Author: rohandebsarkar <[email protected]>
Date:   Sat Jul 9 21:58:33 2022 +0530

    fix profile

commit 0474573
Merge: 4042036 9d71804
Author: rohandebsarkar <[email protected]>
Date:   Sat Jul 9 21:05:27 2022 +0530

    Merge branch 'master' of https://github.com/alshedivat/al-folio into update-bootstrap

commit 4042036
Author: rohandebsarkar <[email protected]>
Date:   Sat Jul 9 20:46:36 2022 +0530

    Update hover to `--global-hover-color` colors

commit eaa6de2
Author: rohandebsarkar <[email protected]>
Date:   Sat Jul 9 19:19:31 2022 +0530

    Update responsive profile image margin

commit 955c0c5
Author: rohandebsarkar <[email protected]>
Date:   Wed Jul 6 16:44:06 2022 +0530

    remove <b> in cv map

commit 637c598
Author: rohandebsarkar <[email protected]>
Date:   Wed Jul 6 12:30:56 2022 +0530

    badge width fix

commit a94d671
Author: rohandebsarkar <[email protected]>
Date:   Wed Jul 6 11:06:25 2022 +0530

    fix post bullets

commit 1905fa0
Author: rohandebsarkar <[email protected]>
Date:   Wed Jul 6 09:29:20 2022 +0530

    consisten bottom margin

commit a54b88e
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 22:37:41 2022 +0530

    fix blog tag color

commit 69d8d3a
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 20:24:41 2022 +0530

    update blog post-tags style

commit ad9c57f
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 19:41:53 2022 +0530

    update publication abbr badge

commit 7891f8d
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 19:22:05 2022 +0530

    fix responsive cv badge

commit 84fcc52
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 18:44:23 2022 +0530

    fix cv map padding

commit 1e0f0ea
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 16:51:46 2022 +0530

    update body container margin

commit 663e04b
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 16:46:17 2022 +0530

    fie responsive navbar border

commit 70373fe
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 14:41:09 2022 +0530

    update body paddings

commit 9a50c00
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 14:22:32 2022 +0530

    update footer sticky-bottom  style

commit 26be662
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 14:19:25 2022 +0530

    update address style

commit e977c30
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 14:12:29 2022 +0530

    update cv badge style

commit 2ea5420
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 14:08:42 2022 +0530

    Update footer style

commit 89cf3e7
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 14:04:00 2022 +0530

    replace dropdown divider with <hr>

commit 1dc0a05
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 12:14:19 2022 +0530

    fix cv text color

commit 86075d4
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 12:08:52 2022 +0530

    Revert "fix publication year color"

    This reverts commit da1888b.

commit 1ac23e9
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 12:08:49 2022 +0530

    Revert "fix font color"

    This reverts commit 9348728.

commit da1888b
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 11:58:14 2022 +0530

    fix publication year color

commit 66a293d
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 11:56:48 2022 +0530

    fix cv preview (fix previous commit) (previous one was done by mistake)

commit 0c61288
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 11:42:31 2022 +0530

    fix publication preview (`max-width` is determined by bootstrap in v5)

commit a53b51b
Author: rohandebsarkar <[email protected]>
Date:   Tue Jul 5 09:39:26 2022 +0530

    fix cv time_table badge

commit 94ff515
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 21:09:09 2022 +0530

    add empty line to `map.html`

commit c5d3f9c
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:49:27 2022 +0530

    Update blog tag padding

commit f46d4cc
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:39:39 2022 +0530

    add padding to cv pdf icon

commit ae5509f
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:37:20 2022 +0530

    fix cv time_table

commit e8b3f86
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:34:21 2022 +0530

    fix cv map

commit 52ffe49
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:10:57 2022 +0530

    fix cv pdf icon

commit 3c81d31
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:06:17 2022 +0530

    remove baseurl (deployment problem) (will be reverted before merging)

commit 691b164
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 15:04:52 2022 +0530

    fix responsive navbar shadow

commit 89be84f
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 14:52:42 2022 +0530

    fix responsive navbar

commit 3b57133
Merge: 6fd8b93 fc52217
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 12:46:38 2022 +0530

    Merge branch 'remove-library-subversions' into update-bootstrap

commit 6fd8b93
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 12:34:28 2022 +0530

    fix footer text

commit 9348728
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 12:13:30 2022 +0530

    fix font color

commit fc52217
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 11:59:26 2022 +0530

    Update cv pdf icon

commit 97a2210
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 11:45:00 2022 +0530

    fix `font-weight`

commit 780fd4f
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 11:34:18 2022 +0530

    fix <hr>

commit 9a34957
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 11:15:45 2022 +0530

    Update a

commit 16560d5
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 11:07:19 2022 +0530

    fix badge

commit 8f466ea
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 09:43:27 2022 +0530

    fix `data-toggle`

commit 925049c
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 08:34:55 2022 +0530

    fix alignment

commit cb59020
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 08:34:47 2022 +0530

    upgrade bootstrap

commit 2090f56
Author: rohandebsarkar <[email protected]>
Date:   Mon Jul 4 08:19:03 2022 +0530

    Reduced libraries to major version only for automatic updates
@rohandebsarkar rohandebsarkar marked this pull request as ready for review January 1, 2023 09:53
@rohandebsarkar
Copy link
Collaborator Author

I think this PR is ready to be reviewed. Though I have tried to fix most of the styles that were broken because of bootstrap v5, but there can be more that went unnoticed. Apart from the necessary changes a lot of stylistic changes were made. Feel free to give any suggestions or ask any questions you might have.

cc @alshedivat @pourmand1376

@jmrplens
Copy link
Contributor

When will this PR be merged?

I'm going to do a clean install and prefer to wait so I don't go crazy later with the transition to Bootstrap 5.

If there is no deadline I'll go ahead and use this branch directly.

@alshedivat

@pourmand1376
Copy link
Collaborator

I like it. Great work. Just one note. I think the blog style should not be bold. It is a little better as it was.
New Blog
image

Old Blog
image

@rohandebsarkar
Copy link
Collaborator Author

@pourmand1376, I don't think I have changed the font style in blog. I think this comes from bootstrap 5, maybe they changed style of h3 headers.

@rohandebsarkar
Copy link
Collaborator Author

When will this PR be merged?

I'm going to do a clean install and prefer to wait so I don't go crazy later with the transition to Bootstrap 5.

If there is no deadline I'll go ahead and use this branch directly.

@alshedivat

Since there are a lot of changes some of those are changes based on my preferences, merging this will take a bit of effort. It will be of helpful if you and others can go through the code and look around the website to see if there are any bugs that went unnoticed by me.

@jmrplens
Copy link
Contributor

Since there are a lot of changes some of those are changes based on my preferences, merging this will take a bit of effort. It will be of helpful if you and others can go through the code and look around the website to see if there are any bugs that went unnoticed by me.

Of course!
I will start with it in two or three days. Since I will be reintroducing everything I already have in the current version, I will be able to test many parts.

I will modify the CV style and the publications, but I will try to test it before modifying it.

@jmrplens
Copy link
Contributor

I had not compiled locally for some time. For MacOS Ventura I had to do the following (in case it helps anyone).
*It's not because of brach, it's because of the computer I had it clean.

xcode-select --install
rbenv install 3.1.3
rbenv init
rbenv global 3.1.3
eval "$(rbenv init - zsh)"
brew install mermaid-cli
cd /path/to/folder
bundle install
bundle exec jekyll serve

I will be testing when I have time.

@jmrplens
Copy link
Contributor

CSS to be improved:

Diagrams in dark mode, low contrast

Screenshot of Google Chrome (16-2-23, 09-45-42)
Screenshot of Google Chrome (16-2-23, 09-45-33)

Disqus title disappear (white) in light mode

Screenshot of Google Chrome (16-2-23, 09-49-02)
Screenshot of Google Chrome (16-2-23, 09-48-22)

@rohandebsarkar
Copy link
Collaborator Author

Are these problems only on this branch?

Article for customizing disqus widgets (have to see if this can be configured through css): https://help.disqus.com/en/articles/1717201-disqus-appearance-customizations

@george-gca
Copy link
Collaborator

Is this still happening? How can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants