Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a new layout for GitHub projects #2702

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

MUmarShahbaz
Copy link
Contributor

Preview

Screenshot 2024-09-16 205708
Screenshot 2024-09-16 205724
Screenshot 2024-09-16 205832
Screenshot 2024-09-16 205819

Additions

  1. Add repositories, type you repo name in the front matter as the following
repositories:
  - KingHowler/Arduino-Language-Support
  - KingHowler/Oscilloscope-Online
  - alshedivat/al-folio
  1. Add icons to your title, to show which languages and tools were used
icons:
  - https://skillicons.dev/icons?i=processing
  - javascript/javascript-original.svg # Note: You don't have to specify the full link to devicons, only the foldername and filename
  - html5/html5-original.svg

@MUmarShahbaz
Copy link
Contributor Author

MUmarShahbaz commented Sep 16, 2024

Fixed layout issues for mobile phones

Preview

@MUmarShahbaz
Copy link
Contributor Author

@george-gca kindly review this as well

@MUmarShahbaz
Copy link
Contributor Author

MUmarShahbaz commented Sep 16, 2024

I know this was previously discussed, but this is the updated version. I am using this for my projects section and it felt like a waste for it to not be a feature.

Next I am thinking about adding some default badges to include
for example I am using this in my about page :

Light Mode

image

Dark Mode

image

the above are the ones for my GitHub stars

Light Mode

Screenshot 2024-09-16 220821

Dark Mode

Screenshot 2024-09-16 220830

And these 2 are for installs on my VS extension

I was thinking about adding a little bit more like these so that they can make them easily? or should they do this themselves?

@george-gca
Copy link
Collaborator

george-gca commented Sep 17, 2024

I was thinking about adding a little bit more like these so that they can make them easily? or should they do this themselves?

I believe they should add them themselves.

I am not sure about the layout of the icons in the desktop version, but tbh I don't currently have a counter-proposal. Have you tested it in the description as smaller icons maybe? But I like the idea of this being a different layout available for the users. Can you create (or maybe modify) a project so it uses this layout, so it can be an example of usage?

_includes/icon.liquid Outdated Show resolved Hide resolved
_includes/icon.liquid Show resolved Hide resolved
_includes/icon.liquid Show resolved Hide resolved
_includes/icon.liquid Show resolved Hide resolved
_layouts/github-project.liquid Show resolved Hide resolved
@MUmarShahbaz
Copy link
Contributor Author

MUmarShahbaz commented Sep 17, 2024

I was thinking about adding a little bit more like these so that they can make them easily? or should they do this themselves?

I believe they should add them themselves.

I am not sure about the layout of the icons in the desktop version, but tbh I don't currently have a counter-proposal. Have you tested it in the description as smaller icons maybe? But I like the idea of this being a different layout available for the users. Can you create (or maybe modify) a project so it uses this layout, so it can be an example of usage?

Then should I center align the title and add the icons below it? Like in the mobile version?

In my opinion it will make the description look awkward, it should be with the title but if we center align it, I don't think it will give a professional look

@george-gca
Copy link
Collaborator

I think the current desktop version doesn't look very professional, but the mobile one looks nice. I agree to not center align it in the desktop version. What about putting it after the description and before the repo card?

@MUmarShahbaz
Copy link
Contributor Author

I think the current desktop version doesn't look very professional, but the mobile one looks nice. I agree to not center align it in the desktop version. What about putting it after the description and before the repo card?

That was how I did it initially but it looked like I was just dumping everything to the left side

@MUmarShahbaz
Copy link
Contributor Author

This is the new design I have come up with

PC Version

image

Mobile Version

image

The icons and the repositories can be any number the user wills it to be

The {{ page.icon }} shown in the project card at the all projects page is displayed as an icon on the page

@MUmarShahbaz
Copy link
Contributor Author

MUmarShahbaz commented Sep 19, 2024

If the new design is better, should I add the description before or after the icons?

Preview : Description before code icons

image

@MUmarShahbaz
Copy link
Contributor Author

I am also thinking about adding a divider right before the repositories, it will keep it separated from the center-aligned content

@MUmarShahbaz
Copy link
Contributor Author

I am using the design on my website, you can take a look directly if you want to
https://kinghowler.github.io/projects/

@george-gca
Copy link
Collaborator

george-gca commented Sep 20, 2024

Can you make it look like this?

image

I believe left aligned keeps the layout more similar to the other ones we are already using. If the user provides an image it could be shown in the left previous to the title like in this image, if not, it could be hidden and the title and everything would be left aligned.

Also I agree to adding a divider before and after the repo cards.

@MUmarShahbaz
Copy link
Contributor Author

I'll try to make it look like that

@alshedivat alshedivat changed the base branch from master to main October 20, 2024 02:47
Copy link

stale bot commented Dec 21, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 21, 2024
@MUmarShahbaz
Copy link
Contributor Author

Oh wow, I had my exams and completely forgot about this. I'll get working on this one.

@stale stale bot removed the wontfix label Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for relaxed-lollipop-b6bc17 failed. Why did it fail? →

Name Link
🔨 Latest commit d6d86b1
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-lollipop-b6bc17/deploys/676952e62a17b200089c8ebf

@MUmarShahbaz
Copy link
Contributor Author

@george-gca I've edited according to your reqiurements.

Preview

image

Requesting for a review. Also idk what the new 4 failed checks are, there were only 3 when I made the PR.

@@ -0,0 +1,27 @@
{% assign addIcon = include.icon %}
<img
{% if addIcon contains 'http' %}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is best to search for :// since it could include files from other sources (e.g. ftp://)

@george-gca
Copy link
Collaborator

2 more things:

  1. Can you make that the image ends with the icons? In your example the icons are positioned at half the image height. Like this:

image

  1. Can you create or modify one of the projects so that it showcases this new template? You can link to this repository as the code example, and even add the information you showed in your previous comment so users get to know how to do this.

@MUmarShahbaz
Copy link
Contributor Author

It's a bit different actually, It's not that the icons are placed at the middle of the image, the Entire Right section starts with the the top of the Image. I could add a simple padding-top to resolve it but I wanted to leave it so that we can use Multiline descriptions. If the description uses multiple line it will automatically shift the icons below.

Or I could have the right section be aligned to the bottom of the image.

@george-gca
Copy link
Collaborator

Can't you instead make the image size relative to the right section, starting it and ending it with the section, but always scaling it? This way the image could be always squared and it would increase its size if the user added a large description.

@MUmarShahbaz
Copy link
Contributor Author

Interesting, I'll look into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants