-
Notifications
You must be signed in to change notification settings - Fork 11.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a new layout for GitHub projects #2702
base: main
Are you sure you want to change the base?
Conversation
@george-gca kindly review this as well |
I know this was previously discussed, but this is the updated version. I am using this for my projects section and it felt like a waste for it to not be a feature. Next I am thinking about adding some default badges to include Light ModeDark Modethe above are the ones for my GitHub stars Light ModeDark ModeAnd these 2 are for installs on my VS extension I was thinking about adding a little bit more like these so that they can make them easily? or should they do this themselves? |
I believe they should add them themselves. I am not sure about the layout of the icons in the desktop version, but tbh I don't currently have a counter-proposal. Have you tested it in the description as smaller icons maybe? But I like the idea of this being a different layout available for the users. Can you create (or maybe modify) a project so it uses this layout, so it can be an example of usage? |
Then should I center align the title and add the icons below it? Like in the mobile version? In my opinion it will make the description look awkward, it should be with the title but if we center align it, I don't think it will give a professional look |
I think the current desktop version doesn't look very professional, but the mobile one looks nice. I agree to not center align it in the desktop version. What about putting it after the description and before the repo card? |
That was how I did it initially but it looked like I was just dumping everything to the left side |
I am also thinking about adding a divider right before the repositories, it will keep it separated from the center-aligned content |
I am using the design on my website, you can take a look directly if you want to |
Can you make it look like this? I believe left aligned keeps the layout more similar to the other ones we are already using. If the user provides an image it could be shown in the left previous to the title like in this image, if not, it could be hidden and the title and everything would be left aligned. Also I agree to adding a divider before and after the repo cards. |
I'll try to make it look like that |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Oh wow, I had my exams and completely forgot about this. I'll get working on this one. |
❌ Deploy Preview for relaxed-lollipop-b6bc17 failed. Why did it fail? →
|
@george-gca I've edited according to your reqiurements. PreviewRequesting for a review. Also idk what the new 4 failed checks are, there were only 3 when I made the PR. |
@@ -0,0 +1,27 @@ | |||
{% assign addIcon = include.icon %} | |||
<img | |||
{% if addIcon contains 'http' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is best to search for ://
since it could include files from other sources (e.g. ftp://)
2 more things:
|
It's a bit different actually, It's not that the icons are placed at the middle of the image, the Entire Right section starts with the the top of the Image. I could add a simple padding-top to resolve it but I wanted to leave it so that we can use Multiline descriptions. If the description uses multiple line it will automatically shift the icons below. Or I could have the right section be aligned to the bottom of the image. |
Can't you instead make the image size relative to the right section, starting it and ending it with the section, but always scaling it? This way the image could be always squared and it would increase its size if the user added a large description. |
Interesting, I'll look into it |
Preview
Additions