fix: Jupyter notebook sometimes not changing to dark theme on first load

alshedivat · Sep 12, 2024 · 065e0aa · 065e0aa
1 parent b30b3f4
commit 065e0aa
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/assets/js/common.js b/assets/js/common.js
@@ -40,16 +40,22 @@ $(document).ready(function () {
   let jupyterTheme = determineComputedTheme();
 
   $(".jupyter-notebook-iframe-container iframe").each(function () {
-    $(this).contents().find("head").append(cssLink);
+    var jupyterIFrame = $(this);
+    jupyterIFrame.contents().find("head").append(cssLink);
 
-    if (jupyterTheme == "dark") {
-      $(this).bind("load", function () {
-        $(this).contents().find("body").attr({
-          "data-jp-theme-light": "false",
-          "data-jp-theme-name": "JupyterLab Dark",
-        });
+    function changeToJupyterDarkTheme() {
+      jupyterIFrame.contents().find("body").attr({
+        "data-jp-theme-light": "false",
+        "data-jp-theme-name": "JupyterLab Dark",
       });
     }
+
+    if (jupyterTheme == "dark") {
+      if (jupyterIFrame[0].contentWindow.document.readyState === "complete") {
+        changeToJupyterDarkTheme();
+      }
+      $(this).bind("load", changeToJupyterDarkTheme);
+    }
   });
 
   // trigger popovers